-
-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: problem with stack of items on the podium after server save #2879
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working as expected.
@phacUFPE Have you tested more house items on stack? We have encounter the same issue and podium is not the only case here, all hose items after save server change order. |
Could you provide the scenarios that the order is being messed up? You commented about other order issue but didn't provided the scenario, since you already have tested would be nice to give us the issue and save time with testing without having any clue of which items are still with order issues. |
Sure, for example put item with id: 28944 and 31219. After SS they will be reordered |
In the file iomapserialize.cpp -> method IOMapSerialize::saveTile(PropWriteStream &stream, std::shared_ptr tile), change the line |
Tested. It fixed in houses problem. |
Description
Player:executeRewardEvents
function that is not being usedFixes #2859
Type of change
Please delete options that are not relevant.
Test Configuration:
Checklist