Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: imbuement shrine and time guardian script errors #2877

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: imbuement shrine and time guardian script errors #2877

wants to merge 5 commits into from

Conversation

luanluciano93
Copy link
Contributor

@luanluciano93 luanluciano93 commented Sep 6, 2024 •
edited
Loading

Description

fix issue #2728

Fixes #2728

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Test Configuration:

  • Server Version: Canary Main
  • Client: 13.40
  • Operating System: Windows 11

Checklist

  • My code follows the style guidelines of this project

@majestyotbr majestyotbr changed the title fix: imbuement_shrine.lua and time_guardian.lua script errors. fix: imbuement shrine and time guardian script errors Sep 6, 2024
FelipePaluco
FelipePaluco approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@FelipePaluco FelipePaluco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudantas
Copy link
Contributor

Please, resolve the conflicts to be able to merge pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@un000000 un000000 un000000 left review comments

@majestyotbr majestyotbr majestyotbr approved these changes

@murilo09 murilo09 murilo09 approved these changes

@FelipePaluco FelipePaluco FelipePaluco approved these changes

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

imbuement_shrine.lua and time_guardian.lua script errors.
6 participants
@luanluciano93 @dudantas @majestyotbr @murilo09 @FelipePaluco @un000000