add: SIMD Instruction Support for MSVC and GCC/Clang #2823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
beats-dh
force-pushed
the
SIMD
branch
3 times, most recently
from
f49beb3
to
e367e87
Compare
W4gNII
approved these changes
Aug 18, 2024
majestyotbr
approved these changes
Aug 18, 2024
mehah
reviewed
Aug 19, 2024
src/game/scheduling/dispatcher.hpp
Outdated
| @@ -207,12 +207,11 @@ class Dispatcher { | |||
| } | |||
|
|
|||
| std::array<std::vector<Task>, static_cast<uint8_t>(TaskGroup::Last)> tasks; | |||
| std::vector<std::shared_ptr<Task>> scheduledTasks; | |||
| phmap::parallel_flat_hash_set_m<std::shared_ptr<Task>> scheduledTasks; | |||
There was a problem hiding this comment.
Why? this is absurdly slow and the vector already has its own mutex.
The dispatcher is practically the core of the project, any ms will make a big difference, the flash_set only serves to maintain the uniqueness of the elements which is practically non-existent and if it exists the ideal is to find the source of the problem.
|
This PR is stale because it has been open 45 days with no activity. |
Chapeleiiro
approved these changes
Sep 24, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request enhances the CMake configuration to detect and enable SIMD instruction support (AVX512, AVX2, SSE, etc.) across different compilers, including MSVC and GCC/Clang. These changes allow the project to more effectively leverage existing optimized code for these SIMD instructions, ensuring improved performance on supported platforms. Additionally, it resolves build warnings on Linux and ensures compatibility across various architectures, maximizing the use of advanced hardware capabilities.