Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk)!: CreateNanoTDF not using functional options #1532

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sujankota
Copy link
Contributor

@sujankota sujankota commented Sep 6, 2024

Resolves #1042

@sujankota sujankota requested review from a team as code owners September 6, 2024 22:05
@sujankota sujankota changed the title fix(sdk) - CreateNanoTDF not using functional options fix(sdk): CreateNanoTDF not using functional options Sep 6, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

1 similar comment
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Warning

This pull request does not reference any issues. Please add a reference to an issue in the body of the pull request description.

@strantalis strantalis changed the title fix(sdk): CreateNanoTDF not using functional options fix(sdk)!: CreateNanoTDF not using functional options Sep 9, 2024
@dmihalcik-virtru
Copy link
Member

IMO we should add a new function, e.g. CreateNanoTDFOpts(), instead of modifying the existing function; this will allow us to deprecate the current behavior and upgrade without breaking anyone downstream

@dmihalcik-virtru
Copy link
Member

See suggestion: #1534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CreateTDF to have shared options to yield NanoTDF and ZTDF
3 participants