fix(core): Adds more explicit 404 status codes #1294
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This should include the first failing fqn for `GetAttributesByValueFqns` instead of a generic error. Largely callers should be able to use errors.Is or errors.As to get more details for commonly expected failures; this is a small step toward that
dmihalcik-virtru
force-pushed
the
feature/better-404s
branch
from
ad26afa
to
bcc4b64
Compare
|
Warning This pull request does not reference any issues. Please add a reference to an issue in the body of the pull request description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should include the first failing fqn for
GetAttributesByValueFqnsinstead of a generic error.Largely callers should be able to use errors.Is or errors.As to get more details for commonly expected failures; this is a small step toward that