Skip to content

Commit

Permalink
fix: correct h2c service appProtocol (#77)
Browse files Browse the repository at this point in the history
Platform's service `appProtocol` is `h2c`. According to [kubernetes
docs](https://kubernetes.io/docs/concepts/services-networking/service/#application-protocol),
it should be `kubernetes.io/h2c`.

HTTP Requests were being received as HTTP/1.1, rather than HTTP2 causing
gRPC requests to fail.
  • Loading branch information
imdominicreed committed Aug 15, 2024
1 parent 02f8839 commit 25a1ae8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/platform/templates/headless-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ spec:
ports:
- port: {{ .Values.service.port }}
targetPort: http2
appProtocol: {{ if .Values.server.tls.enabled }}http2{{ else }}h2c{{ end }}
appProtocol: {{ if .Values.server.tls.enabled }}http2{{ else }}kubernetes.io/h2c{{ end }}
protocol: TCP
name: http2
selector:
Expand Down
2 changes: 1 addition & 1 deletion charts/platform/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ spec:
ports:
- port: {{ .Values.service.port }}
targetPort: http2
appProtocol: {{ if .Values.server.tls.enabled }}http2{{ else }}h2c{{ end }}
appProtocol: {{ if .Values.server.tls.enabled }}http2{{ else }}kubernetes.io/h2c{{ end }}
protocol: TCP
name: http2
selector:
Expand Down

0 comments on commit 25a1ae8

Please sign in to comment.