Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-3489: multi-nic change for QE env #4031

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

USHIFT-3489: multi-nic change for QE env #4031

wants to merge 1 commit into from
+17 −19

Conversation

agullon
Copy link
Contributor

@agullon agullon commented Oct 7, 2024

Which issue(s) this PR addresses:

Closes #

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 7, 2024 •
edited by openshift-ci bot
Loading

@agullon: This pull request references USHIFT-3489 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: agullon
Once this PR has been reviewed and has the lgtm label, please assign pmtk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agullon
Copy link
Contributor Author

agullon commented Oct 7, 2024

Execution example from my local PC: mul-nic_run.zip

ggiguash
ggiguash reviewed Oct 20, 2024
View reviewed changes
test/suites/network/multi-nic.robot
@@ -21,7 +21,7 @@ ${USHIFT_HOST_IP2} ${EMPTY}
${NIC1_NAME} ${EMPTY}
${NIC2_NAME} ${EMPTY}
${NICS_COUNT} 2
${NMCLI_CMD} nmcli -f name,type connection | awk '$2 == "ethernet" {print $1}' | sort
${NMCLI_CMD} nmcli connection | grep ethernet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change the command?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggiguash ggiguash ggiguash left review comments

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agullon @openshift-ci-robot @ggiguash