-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: update hive version #6811
base: master
Are you sure you want to change the base?
Conversation
@tsorya: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tsorya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6811 +/- ##
=======================================
Coverage 68.73% 68.74%
=======================================
Files 249 249
Lines 37278 37278
=======================================
+ Hits 25622 25625 +3
+ Misses 9374 9372 -2
+ Partials 2282 2281 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
d427744
to
e7d6fe2
Compare
/retest |
/lgtm |
/hold Revision e7d6fe2 was retested 3 times: holding |
/retest |
@tsorya: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/unhold |
Updating hive version in order to import assisted in image based as it is required by installer.
Can't take the latest hive as this creates circle dependency between assisted, hive and installer
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist