Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed READ_ACTIONS required by TermsAggregationEvaluator #4582

Merged
merged 2 commits into from
Jul 29, 2024

Commits on Jul 19, 2024

  1. Fixed READ_ACTIONS required by TermsAggregationEvaluator

    The READ_ACTIONS array is passed by TermsAggregationEvaluator to securityRoles.getAllPermittedIndicesForDashboards() which checks whether privileges are available for all actions specified in READ_ACTIONS. READ_ACTIONS also contained the string "indices:data/read/field_caps*", which is actually wrong, because it is not an action but looks like pattern. However, the code behind securityRoles.getAllPermittedIndicesForDashboards() will never treat these strings as patterns. The "*" is only considered a normal, bare character. Patterns (via WildcardMatcher class) will be only applied to these strings.
    
    This had the effect that a bare privilege "indices:data/read/field_caps" was not sufficient to fulfill the requirement. It was necessary to have either "indices:data/read/field_caps*" in ones roles.yml or something broader like "indices:data/read/*". The latter is the most likely case, which is the reason why in most cases this gets unnoticed.
    
    Signed-off-by: Nils Bandener <[email protected]>
    nibix committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    94c756f View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Replaced hard-coded action names by constants from core

    Signed-off-by: Nils Bandener <[email protected]>
    nibix committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    57bd4f3 View commit details
    Browse the repository at this point in the history