feat: http proxy support for oidc #2024
Conversation
Manuelraa
requested review from
cliu123,
cwperks,
DarshitChanpura,
derek-ho,
RyanL1997 and
stephen-crawford
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2024 +/- ##
=======================================
Coverage 70.61% 70.61%
=======================================
Files 97 97
Lines 2600 2600
Branches 387 387
=======================================
Hits 1836 1836
Misses 668 668
Partials 96 96 ☔ View full report in Codecov by Sentry. |
|
@Manuelraa Can you change the base branch of this PR to |
|
The changes in this PR look ok to me. Wdyt about filing an issue about adding a functional test that covers a setup with an OIDC IdP behind a proxy? |
There was a problem hiding this comment.
+1 to @cwperks comment. Let's rebase this main and then backport it using backport 2.x label.
Sure #2043 created |
Rebased to |
Resolves: opensearch-project#911 Signed-off-by: manuelraa <[email protected]>
Signed-off-by: Manuelraa <[email protected]>
* feat: http proxy support for oidc Resolves: #911 Signed-off-by: manuelraa <[email protected]> * chore: reduce code duplication for agent configuration Signed-off-by: Manuelraa <[email protected]> --------- Signed-off-by: manuelraa <[email protected]> Signed-off-by: Manuelraa <[email protected]> (cherry picked from commit fe847af)
* feat: http proxy support for oidc Resolves: #911 Signed-off-by: manuelraa <[email protected]> * chore: reduce code duplication for agent configuration Signed-off-by: Manuelraa <[email protected]> --------- Signed-off-by: manuelraa <[email protected]> Signed-off-by: Manuelraa <[email protected]> (cherry picked from commit fe847af) Co-authored-by: Manuelraa <[email protected]>
Description
Add http proxy support for oidc
Category
Enhancement
Why these changes are required?
Users of OpenSearch Dashboards in Companies which require use of http proxy struggle to implement OIDC.
What is the old behavior before changes and new behavior after changes?
ODIC http requests now support proxies.
Issues Resolved
Resolves: #911
Testing
Starting OpenSearch and OpenSearch Dashboards locally. Configure OIDC and set
https_proxyvariable. Then validate that requests are sent to proxy.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.