Add the capability to use RoleBindings instead of ClusterRoleBindings #841
+60
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nilushan Costa <[email protected]>
nilushancosta
requested review from
idanl21,
dbason,
swoehrl-mw,
prudhvigodithi,
jochenkressin,
pchmielnik and
salyh
as code owners
|
@swoehrl-mw would you be able to have a look at this PR? |
swoehrl-mw
requested changes
Oct 11, 2024
Signed-off-by: Nilushan Costa <[email protected]>
Signed-off-by: Nilushan Costa <[email protected]>
…osta/opensearch-k8s-operator into use-role-bindings-flag
@swoehrl-mw I changed it as requested |
swoehrl-mw
requested changes
Oct 18, 2024
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRoleBinding | ||
| metadata: | ||
| name: {{ include "opensearch-operator.fullname" . }}-{{ .Release.Namespace }}-manager-cluster-rolebinding |
There was a problem hiding this comment.
Suggested change
| name: {{ include "opensearch-operator.fullname" . }}-{{ .Release.Namespace }}-manager-cluster-rolebinding | |
| name: {{ include "opensearch-operator.fullname" . }}-{{ .Release.Namespace }}-manager-rolebinding |
Name should stay the same as it is now, IMO it is also not a problem if rolebinding and clusterrolebinding are named the same
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRoleBinding | ||
| metadata: | ||
| name: {{ include "opensearch-operator.fullname" . }}-{{ .Release.Namespace }}-proxy-cluster-rolebinding |
There was a problem hiding this comment.
Suggested change
| name: {{ include "opensearch-operator.fullname" . }}-{{ .Release.Namespace }}-proxy-cluster-rolebinding | |
| name: {{ include "opensearch-operator.fullname" . }}-{{ .Release.Namespace }}-proxy-rolebinding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new key to the Helm values named
useRoleBindingswhich when set totruecreates Kubernetes RoleBindings instead of ClusterRoleBindingsIssues Resolved
Closes #831
Check List
make lint)If CRDs are changed:
make manifests) and also copied into the helm chartPlease refer to the PR guidelines before submitting this pull request.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.