Add import helper function to optimize data uploading time #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qingyang(Abby) Hu <[email protected]>
abbyhu2000
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
Signed-off-by: Qingyang(Abby) Hu <[email protected]>
abbyhu2000
force-pushed
the
add_import_helper
branch
from
aaaf348
to
6276c8e
Compare
kavilla
approved these changes
Oct 4, 2023
Signed-off-by: Qingyang(Abby) Hu <[email protected]>
AMoo-Miki
reviewed
Oct 4, 2023
Comment on lines
100
to
107
| let queryString = ''; | ||
| if (typeof index === 'string') { | ||
| queryString = index; | ||
| } else if (Array.isArray(index)) { | ||
| index.forEach(value => queryString += `${value},`); | ||
| } else { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Suggested change
| let queryString = ''; | |
| if (typeof index === 'string') { | |
| queryString = index; | |
| } else if (Array.isArray(index)) { | |
| index.forEach(value => queryString += `${value},`); | |
| } else { | |
| return; | |
| } | |
| const queryString = (Array.isArray(index) ? index : [index]).join(','); |
There was a problem hiding this comment.
const items = (Array.isArray(index) ? index : [index]);
if (items.some(value => typeof value !== 'string')) return;
const queryString = items.join(',');Signed-off-by: Qingyang(Abby) Hu <[email protected]>
kavilla
approved these changes
Oct 4, 2023
AMoo-Miki
approved these changes
Oct 4, 2023
ananzh
approved these changes
Oct 4, 2023
ashwin-pc
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a function to read docs from a file and import them to OpenSearch only when the indices do not already exist in order to optimize the data uploading time in cypress tests.
Issues Resolved
resolves opensearch-project/opensearch-dashboards-functional-test#903
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.