feat: freeze browser version to 112 #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuZhou-Joe
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
ruanyl,
wanglam and
raintygao
as code owners
peterzhuamazon
approved these changes
Jun 14, 2024
| @@ -127,7 +139,11 @@ jobs: | |||
| - run: npx cypress cache path | |||
| - name: Cypress tests | |||
| uses: cypress-io/github-action@v2 | |||
| env: | |||
| # remove success video to save space and memory | |||
| CYPRESS_DELETE_SUCCESS_VIDEOS: true | |||
There was a problem hiding this comment.
Instead of record then delete videos, just disable recording:
https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/integtest.sh#L219-L223
There was a problem hiding this comment.
Yes, but we want to keep the video if the specs failed.
There was a problem hiding this comment.
And even if we downgrade chromium version to 112, the security test will still fail. I am trying to reduce the memory our test cases are using.
ruanyl
approved these changes
Jun 14, 2024
| @@ -19,7 +19,7 @@ | |||
| // *********************************************************** | |||
|
|
|||
| // Import commands.js using ES2015 syntax: | |||
| import '../utils/commands'; | |||
| import { currentBackendEndpoint } from '../utils/commands'; | |||
There was a problem hiding this comment.
There is a lint warning in this file that we import '../utils/commands' twice, so I combine the two import into one.
|
Convert to draft as it is still WIP and under verification. |
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
force-pushed
the
feature/freeze-chromium-version
branch
from
fb436b2
to
dc48b55
Compare
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
* feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: add comment Signed-off-by: SuZhou-Joe <[email protected]> * feat: add comment Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit 03548a6)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
* feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: add comment Signed-off-by: SuZhou-Joe <[email protected]> * feat: add comment Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit 03548a6)
SuZhou-Joe
added a commit
that referenced
this pull request
Jun 18, 2024
* feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: add comment Signed-off-by: SuZhou-Joe <[email protected]> * feat: add comment Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: freeze browser version Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize test Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit 03548a6) Co-authored-by: SuZhou-Joe <[email protected]>
peterzhuamazon
added a commit
that referenced
this pull request
Jun 19, 2024
This reverts commit 03548a6.
peterzhuamazon
added a commit
that referenced
this pull request
Jun 19, 2024
peterzhuamazon
added a commit
that referenced
this pull request
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Github CI is using the latest chromium to run the Cypress test, which leads to forever hang in some test cases.
According to #4241 , we will freeze the Chromium version to 112, exactly same as what Jenkins CI uses.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.