Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record OpenSearch-Dashboards failed test cases in test-report.yml #5111

Merged

Conversation

peterzhuamazon
Copy link
Member

Description

Record OpenSearch-Dashboards failed test cases in test-report.yml

Issues Resolved

opensearch-project/opensearch-metrics#68

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@prudhvigodithi
Copy link
Collaborator

Hey @peterzhuamazon thanks, do we need all the .xml files to be part of the this change or can we just test on one .xml?

@peterzhuamazon
Copy link
Member Author

Hey @peterzhuamazon thanks, do we need all the .xml files to be part of the this change or can we just test on one .xml?

We need all of the xml, due to in cypress each plugin would run multiple test js file, and each xml corresponding to one js.

@prudhvigodithi
Copy link
Collaborator

Just a thought, I think for testing peter we can remove the all the xml files just keep one and update here https://github.com/opensearch-project/opensearch-build/pull/5111/files#diff-a44612e37c0352c6226189afb70d84c146f4dfe5982cfc6caf445e462a3664a3, then the tests should pass as well right?

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Oct 17, 2024

Just a thought, I think for testing peter we can remove the all the xml files just keep one and update here https://github.com/opensearch-project/opensearch-build/pull/5111/files#diff-a44612e37c0352c6226189afb70d84c146f4dfe5982cfc6caf445e462a3664a3, then the tests should pass as well right?

We need to test the for loop with multiple xmls instead of only limit to one.
We are fine with these data as they are just for test.

Thanks.

@peterzhuamazon peterzhuamazon merged commit 9daa8f3 into opensearch-project:main Oct 17, 2024
9 of 10 checks passed
@peterzhuamazon peterzhuamazon deleted the test-case-opensearch-3 branch October 17, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants