Refactor integ-test notification #5081
Conversation
Signed-off-by: Sayali Gaikawad <[email protected]>
gaiksaya
requested review from
dblock,
peterzhuamazon,
rishabh6788,
zelinh,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
|
|
||
|
|
||
| pipeline { | ||
| agent { label 'Jenkins-Agent-Ubuntu2004-X64-M58xlarge-Single-Host' } |
There was a problem hiding this comment.
Should not use this as this is specifically for gradle check and only runs once and delete.
There was a problem hiding this comment.
Do you have any recommendation?
There was a problem hiding this comment.
If you want to use ubuntu then use the docker builder one
If not, then use a generic x64 docker host.
There was a problem hiding this comment.
Updated to Jenkins-Agent-AL2023-X64-C54xlarge-Docker-Host
Thanks!
There was a problem hiding this comment.
So you are going to run directly on agent node without docker container?
There was a problem hiding this comment.
Yes! Followed the same patter we are using for https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/gradle/gradle-check-flaky-test-issue-creation.jenkinsfile
There was a problem hiding this comment.
Adding @prudhvigodithi to take a look to update that jenkinsfile to use other runners.
I still think using a docker container here is more clean.
As using the agent might have cleanup issues.
There was a problem hiding this comment.
Used Jenkins-Agent-Ubuntu2004-X64-M58xlarge-Single-Host in jenkinsfile https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/gradle/gradle-check-flaky-test-issue-creation.jenkinsfile because:
- This
gradle-check-flaky-test-issue-creation.jenkinsfilecomes under the same family gradle-check hence used the same. - Mainly using
Jenkins-Agent-Ubuntu2004-X64-M58xlarge-Single-Hostbecause of the latestcurlversion which supports--aws-sigv4flag.
But looks to me like this Jenkins-Agent-AL2023-X64-C54xlarge-Docker-Host (coming from https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/distribution-build.jenkinsfile#L876-L881) also has that latest curl version that supports --aws-sigv4 flag.
| H */6 * * * %INPUT_MANIFEST=2.17.2/opensearch-2.17.2.yml | ||
| H */6 * * * %INPUT_MANIFEST=2.18.0/opensearch-2.18.0.yml | ||
| H */6 * * * %INPUT_MANIFEST=3.0.0/opensearch-3.0.0.yml |
There was a problem hiding this comment.
Shall we update the input manifest generation workflow to update this section alongside check-for-build as well?
There was a problem hiding this comment.
Yes! Will take that up in next iteration.
There was a problem hiding this comment.
Could you create an issue for that since you seems to close #5038 in this PR.
Signed-off-by: Sayali Gaikawad <[email protected]>
|
Created the workflow in jenkins : https://build.ci.opensearch.org/job/integ-test-notification/ |
Description
Issues Resolved
closes #5038
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.