Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add osd 2.9.0 related manifests to build repo #3659

Merged

Conversation

peterzhuamazon
Copy link
Member

Description

Add osd 2.9.0 related manifests to build repo

Issues Resolved

#3616

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #3659 (18202a9) into main (ab3297e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3659   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files         182      182           
  Lines        5408     5408           
=======================================
  Hits         4950     4950           
  Misses        458      458           

@gaiksaya
Copy link
Member

https://github.com/opensearch-project/OpenSearch-Dashboards/blob/2.x/package.json#L14 OSD has not incremented their version in 2.x yet. That's why manifest workflow did not create a manifest: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/2.x/package.json#L14 :(

@peterzhuamazon
Copy link
Member Author

They are awaiting: opensearch-project/OpenSearch-Dashboards#1560 (comment)

We can hold this PR and wait tho.

Thanks.

@peterzhuamazon
Copy link
Member Author

@kavilla has since bump the version to 2.9.0.

@peterzhuamazon
Copy link
Member Author

Replace #3674.

@peterzhuamazon peterzhuamazon merged commit daeeee9 into opensearch-project:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants