-download task support for geoip #3373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rajeshLovesToCode <[email protected]>
rajeshLovesToCode
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed,
dlvenable and
oeyh
as code owners
Signed-off-by: rajeshLovesToCode <[email protected]>
Signed-off-by: rajeshLovesToCode <[email protected]>
dlvenable
previously approved these changes
Sep 27, 2023
kkondaka
reviewed
Oct 2, 2023
| assertThat(geoData.get("country_iso_code"), equalTo("US")); | ||
| assertThat(geoData.get("ip"), equalTo("2001:4860:4860:0:0:0:0:8888")); | ||
| assertThat(geoData.get("country_iso_code"), equalTo("FR")); | ||
| assertThat(geoData.get("ip"), equalTo("2a02:ec00:0:0:0:0:0:0")); |
There was a problem hiding this comment.
Nit. It probably better to make this as
assertThat(geoData.get("ip"), equalTo(IP));
There was a problem hiding this comment.
hi @kkondaka pr updated with the fix
kkondaka
reviewed
Oct 2, 2023
| assertThat(geoData.get("country_name"), equalTo("United States")); | ||
| assertThat(geoData.get("ip"), equalTo("2001:4860:4860:0:0:0:0:8888")); | ||
| assertThat(geoData.get("country_name"), equalTo("France")); | ||
| assertThat(geoData.get("ip"), equalTo("2a02:ec00:0:0:0:0:0:0")); |
There was a problem hiding this comment.
hi @kkondaka pr updated with the fix
kkondaka
previously approved these changes
Oct 2, 2023
Signed-off-by: rajeshLovesToCode <[email protected]>
rajeshLovesToCode
dismissed stale reviews from kkondaka and dlvenable
via
2888031
kkondaka
approved these changes
Oct 3, 2023
dlvenable
approved these changes
Oct 3, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
* -download task support for geoip Signed-off-by: rajeshLovesToCode <[email protected]> * -download task support for geoip Signed-off-by: rajeshLovesToCode <[email protected]> * -download task support for geoip Signed-off-by: rajeshLovesToCode <[email protected]> * -fix for geoip IP constant Signed-off-by: rajeshLovesToCode <[email protected]> (cherry picked from commit 56b74be)
dlvenable
pushed a commit
that referenced
this pull request
Oct 5, 2023
* -download task support for geoip Signed-off-by: rajeshLovesToCode <[email protected]> * -download task support for geoip Signed-off-by: rajeshLovesToCode <[email protected]> * -download task support for geoip Signed-off-by: rajeshLovesToCode <[email protected]> * -fix for geoip IP constant Signed-off-by: rajeshLovesToCode <[email protected]> (cherry picked from commit 56b74be) Co-authored-by: rajeshLovesToCode <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rajeshLovesToCode [email protected]
Description
Implemented downlaod maxmind test mmdb files to resource folder
Issues Resolved
GitHub-issue #253
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.