Behavioral change to Avro codecs and schema handling #3238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hema to get data, rather than iterate over the entire record. Fix Avro arrays which were only supporting arrays of strings previously. Signed-off-by: David Venable <[email protected]>
…ely on the schema rather than the incoming event. If the schema is auto-generated, then the incoming event data must continue to match. Signed-off-by: David Venable <[email protected]>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed and
oeyh
as code owners
It depends on the schema. If the schema does not allow it to be This test should cover it: |
asifsmohammed
approved these changes
Aug 24, 2023
graytaylor0
approved these changes
Aug 24, 2023
| for (String key : getKeyNames(schema, eventData, codecContext, rootOfData)) { | ||
| final Schema.Field field = schema.getField(key); | ||
| if (field == null) { | ||
| throw new RuntimeException("The event has a key ('" + key + "') which is not included in the schema."); |
There was a problem hiding this comment.
What is the behavior for this exception? We include it as one of the Events that has to be dropped?
There was a problem hiding this comment.
This will show in the sampled log as merged in #3242.
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 24, 2023
Change the behavior of Avro-based codecs. When a schema is defined, rely on the schema rather than the incoming event. If the schema is auto-generated, then the incoming event data must continue to match. Fix Avro arrays which were only supporting arrays of strings previously. Signed-off-by: David Venable <[email protected]> (cherry picked from commit f17e833)
dlvenable
added a commit
that referenced
this pull request
Aug 24, 2023
Change the behavior of Avro-based codecs. When a schema is defined, rely on the schema rather than the incoming event. If the schema is auto-generated, then the incoming event data must continue to match. Fix Avro arrays which were only supporting arrays of strings previously. Signed-off-by: David Venable <[email protected]> (cherry picked from commit f17e833) Co-authored-by: David Venable <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a fundamental change to how the Avro-based codecs (Avro and Parquet) handle mapping Events to Avro records.
There are now two cases which are handled differently:
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.