Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jenkins release workflow and refactor GHA workflow #3204

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

gaiksaya
Copy link
Member

Description

This PR adds below changes:

  • Add input type as boolean to GHA release workflow
  • Add permissions required by the token to create a draft release
  • Add refactored jenkins workflow file to this repository. See old workflow file here

Once this PR is merged I'll take care of adding the necessary webhook token.

Issues Resolved

Resolves opensearch-project/opensearch-build#3842

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks good!

remote: 'https://github.com/opensearch-project/opensearch-build-libraries.git',
]))

def VERSION = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious as to the use of a global variable here. Is there not a way to pass the parameter from the trigger to the job directly?

@dlvenable dlvenable merged commit 74798f3 into opensearch-project:main Aug 22, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Jenkins trigger for Data Prepper release build
3 participants