Improve the S3 sink integration tests combinations #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… more consistent and avoid some redundant tests, thus also running faster. Sets up to have fewer combinations while testing all codecs. Signed-off-by: David Venable <[email protected]>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed and
oeyh
as code owners
engechas
approved these changes
Aug 23, 2023
asifsmohammed
approved these changes
Aug 23, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
… more consistent and avoid some redundant tests, thus also running faster. Sets up to have fewer combinations while testing all codecs. (#3199) Signed-off-by: David Venable <[email protected]> (cherry picked from commit f9f3729)
dlvenable
added a commit
that referenced
this pull request
Aug 25, 2023
… more consistent and avoid some redundant tests, thus also running faster. Sets up to have fewer combinations while testing all codecs. (#3199) (#3248) Signed-off-by: David Venable <[email protected]> (cherry picked from commit f9f3729) Co-authored-by: David Venable <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes improvements to the S3 sink tests. It reduces sample size, removes some tests which would often cause the JVM to run out of memory, and removes redundant tests. It also sets up a combination for codecs which will not cause the scenarios to grow out of hand.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.