Added validations in include and exclude keys #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asif Sohail Mohammed <[email protected]>
asifsmohammed
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
dlvenable and
oeyh
as code owners
dlvenable
approved these changes
Aug 16, 2023
graytaylor0
reviewed
Aug 18, 2023
| }); | ||
| excludeKeys.forEach(key -> { | ||
| if(key.contains("/")) | ||
| throw new InvalidPluginConfigurationException("exclude_keys cannot contain /"); |
There was a problem hiding this comment.
Does this mean we don't support nested keys? seems like it should be supported like we do for delete_entries processor
There was a problem hiding this comment.
We decided not to support it for now, and add it later.
#3163 (comment)
There was a problem hiding this comment.
We already do not support it.
So this change just validates that users don't try to use this. See this comment and thread for more details:
graytaylor0
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/at start of key and removing/at end of key./in keysIssues Resolved
partially resolves #3163
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.