Fix NPE on s3 source stopping without sqs, stop s3 scan worker thread… #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on stopping of the s3 source Signed-off-by: Taylor Gray <[email protected]>
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed,
dlvenable and
oeyh
as code owners
engechas
approved these changes
Aug 16, 2023
| sqsService.stop(); | ||
| } | ||
|
|
||
| if (Objects.nonNull(s3ScanService) && Objects.nonNull(sourceCoordinator)) { |
There was a problem hiding this comment.
Should these be stopped independently? Something like
if (Objects.nonNull(s3ScanService)) {
s3ScanService.stop();
}
if (Objects.nonNull(sourceCoordinator)) {
sourceCoordinator.giveUpPartitions();
}
asifsmohammed
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… on stopping of the s3 source
Description
The s3 source was throwing a NPE during the
stopmethod when sqs was not configured.Additionally, the s3 scan worker thread was not being interrupted when
stopwas called on the s3Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.