Minor fixes to Kafka Source #3174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
cmanning09,
asifsmohammed,
dlvenable and
oeyh
as code owners
cmanning09
reviewed
Aug 16, 2023
| @@ -33,7 +33,7 @@ public class TopicConfig { | |||
| static final Duration DEFAULT_RETRY_BACKOFF = Duration.ofSeconds(10); | |||
| static final Duration DEFAULT_RECONNECT_BACKOFF = Duration.ofSeconds(10); | |||
| static final Integer DEFAULT_MAX_PARTITION_FETCH_BYTES = 1048576; | |||
| static final Duration DEFAULT_MAX_POLL_INTERVAL = Duration.ofSeconds(300000); | |||
| static final Duration DEFAULT_MAX_POLL_INTERVAL = Duration.ofSeconds(300); | |||
There was a problem hiding this comment.
Should we set a maximum value on maxRetryDelay? A user could set it back to 300000
Signed-off-by: Krishna Kondaka <[email protected]>
cmanning09
approved these changes
Aug 16, 2023
| public static class SslAuthConfig { | ||
| // TODO Add Support for SSL authentication types like | ||
| // one-way or two-way authentication | ||
| /* |
There was a problem hiding this comment.
Take it or leave it: I would recommend deleting this dead code and leave a single like comment instead of commenting it out a large code block with no description for the TODO.
hshardeesi
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change contains the following fixes
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.