Only log that the scan is complete one time for s3 scan #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Taylor Gray <[email protected]>
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed,
dlvenable and
oeyh
as code owners
|
|
||
| if (!(Boolean) globalStateMap.get(SINGLE_SCAN_COMPLETE)) { | ||
| LOG.info("Single S3 scan has already been completed"); | ||
| globalStateMap.put(SINGLE_SCAN_COMPLETE, true); |
There was a problem hiding this comment.
What's the difference between SINGLE_SCAN_COMPLETE and SCAN_COUNT? can we just use SCAN_COUNT to determine if scan is complete?
There was a problem hiding this comment.
SCAN_COUNT could block scanning since the global state doesn't go away. so it's better to keep it separate for this log
cmanning09
reviewed
Aug 15, 2023
| LOG.info("Skipping scan because the buckets have already been scanned once"); | ||
|
|
||
| if (!(Boolean) globalStateMap.get(SINGLE_SCAN_COMPLETE)) { | ||
| LOG.info("Single S3 scan has already been completed"); |
There was a problem hiding this comment.
Why log only during the seconds attempt at scanning? Why not log once the first scan is complete?
There was a problem hiding this comment.
We could log after the first scan, but with source coordination this will only get run again after all the scanned objects have been processed, so as far as timing of the log it makes more since when trying to scan again
asifsmohammed
approved these changes
Aug 15, 2023
cmanning09
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Track when single scan is complete to only log once when the scan has already been completed
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.