Make max partition fetch bytes configurable #3115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
cmanning09,
asifsmohammed,
dlvenable and
oeyh
as code owners
hshardeesi
approved these changes
Aug 4, 2023
dlvenable
requested changes
Aug 4, 2023
| @@ -92,6 +93,9 @@ public class TopicConfig { | |||
| @JsonProperty("max_record_fetch_time") | |||
| private Duration maxRecordFetchTime = DEFAULT_MAX_RECORD_FETCH_TIME; | |||
|
|
|||
| @JsonProperty("max_partition_fetch_bytes") | |||
| private Integer maxPartitionFetchBytes = DEFAULT_MAX_PARTITION_FETCH_BYTES; | |||
There was a problem hiding this comment.
We should make use of Data Prepper's ByteCount type. See #3099 for an example of using this in the CloudWatch logs config.
dlvenable
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make max partition fetch bytes configurable. Added config option to set max partition fetch bytes.
Also fixed the code to honor configured values for fetch bytes min and max poll interval.
Also fixed code to get authentication config only once and not for every topic.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.