GitHub-Issue#2778: Added README for CloudWatch Logs Sink #3101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 1, 2023 16:08
Signed-off-by: Marcos Gonzalez Mayedo <[email protected]>
Signed-off-by: Marcos Gonzalez Mayedo <[email protected]>
MaGonzalMayedo
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed,
dlvenable and
oeyh
as code owners
Signed-off-by: Marcos Gonzalez Mayedo <[email protected]>
dlvenable
previously approved these changes
Aug 2, 2023
markkuhn
reviewed
Aug 2, 2023
| aws: | ||
| region: us-east-1 | ||
| sts_role_arn: arn:aws:iam::123456789012:role/Data-Prepper | ||
| sts_header_overrides: |
There was a problem hiding this comment.
all have example data except this? why?
There was a problem hiding this comment.
Sorry about that. I missed those values in the original draft. I have added in example values now and another parameter that was missing.
There was a problem hiding this comment.
We probably don't even need to show this in the example. It is not commonly used.
markkuhn
reviewed
Aug 2, 2023
markkuhn
reviewed
Aug 2, 2023
Co-authored-by: Mark Kuhn <[email protected]> Signed-off-by: Marcos Gonzalez Mayedo <[email protected]>
Co-authored-by: Mark Kuhn <[email protected]> Signed-off-by: Marcos Gonzalez Mayedo <[email protected]>
Signed-off-by: Marcos Gonzalez Mayedo <[email protected]>
Signed-off-by: Marcos Gonzalez Mayedo <[email protected]>
markkuhn
approved these changes
Aug 2, 2023
dlvenable
approved these changes
Aug 2, 2023
| aws: | ||
| region: us-east-1 | ||
| sts_role_arn: arn:aws:iam::123456789012:role/Data-Prepper | ||
| sts_header_overrides: |
There was a problem hiding this comment.
We probably don't even need to show this in the example. It is not commonly used.
markkuhn
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change introduces the README for the CloudWatch Logs Sink.
Issues Resolved
This PR will work towards resolving CWL-Sink for Data-Prepper [Issue https://github.com/https://github.com/https://github.com/https://github.com/https://github.com/https://github.com/https://github.com//issues/2778]
Link: #2778 (comment)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.