-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove brackets feature option #3035
Merged
asifsmohammed
merged 16 commits into
opensearch-project:main
from
shenkw1:include-brackets
Jul 24, 2023
Merged
Remove brackets feature option #3035
asifsmohammed
merged 16 commits into
opensearch-project:main
from
shenkw1:include-brackets
Jul 24, 2023
+58
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kat Shen <[email protected]>
Signed-off-by: Kat Shen <[email protected]>
Signed-off-by: Kat Shen <[email protected]>
Signed-off-by: Kat Shen <[email protected]>
Signed-off-by: Kat Shen <[email protected]>
…e is false Signed-off-by: Kat Shen <[email protected]>
shenkw1
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed,
dlvenable and
oeyh
as code owners
July 17, 2023 19:11
Signed-off-by: Kat Shen <[email protected]>
Signed-off-by: Kat Shen <[email protected]>
Signed-off-by: Kat Shen <[email protected]>
chenqi0805
reviewed
Jul 17, 2023
...r/src/main/java/org/opensearch/dataprepper/plugins/processor/keyvalue/KeyValueProcessor.java
Outdated
Show resolved
Hide resolved
.../test/java/org/opensearch/dataprepper/plugins/processor/keyvalue/KeyValueProcessorTests.java
Show resolved
Hide resolved
Signed-off-by: Kat Shen <[email protected]>
Signed-off-by: Kat Shen <[email protected]>
Signed-off-by: Kat Shen <[email protected]>
Signed-off-by: Kat Shen <[email protected]>
Signed-off-by: Kat Shen <[email protected]>
Signed-off-by: Kat Shen <[email protected]>
chenqi0805
reviewed
Jul 21, 2023
Signed-off-by: Kat Shen <[email protected]>
chenqi0805
approved these changes
Jul 21, 2023
asifsmohammed
approved these changes
Jul 24, 2023
chenqi0805
pushed a commit
that referenced
this pull request
Jul 25, 2023
*add remove brackets feature option Signed-off-by: Kat Shen <[email protected]> --------- Signed-off-by: Kat Shen <[email protected]> Co-authored-by: Kat Shen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Specify whether to keep or remove square brackets, curly braces, and/or parentheses
Issues Resolved
#892
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.