Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SqsWorker error messages #2991

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Fix SqsWorker error messages #2991

merged 1 commit into from
Jul 7, 2023

Conversation

kkondaka
Copy link
Collaborator

@kkondaka kkondaka commented Jul 7, 2023

Description

Fix SqsWorker error messages.

  1. SQSWorker tries to delete empty list of objects which results in error message that's misleading. This fix avoids that by check for empty message list before invoking delete
  2. SQS worker message when deletion fails has is constructed incorrectly. Fixed it by constructing the error message correctly.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
    • New functionality has javadoc added
  • [ X] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Fix SqsWorker error messages
bb6f84b 
Signed-off-by: Krishna Kondaka <[email protected]>
@kkondaka kkondaka merged commit 45b6e55 into opensearch-project:main Jul 7, 2023
23 of 24 checks passed
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 11, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 11, 2023
@kkondaka @github-actions
Fix SqsWorker error messages (#2991)
fa9168a 
Signed-off-by: Krishna Kondaka <[email protected]>
Co-authored-by: Krishna Kondaka <[email protected]>
(cherry picked from commit 45b6e55)
kkondaka added a commit that referenced this pull request Jul 11, 2023
@opensearch-trigger-bot @kkondaka
Fix SqsWorker error messages (#2991) (#3002)
2025e47 
Signed-off-by: Krishna Kondaka <[email protected]>
Co-authored-by: Krishna Kondaka <[email protected]>
(cherry picked from commit 45b6e55)

Co-authored-by: kkondaka <[email protected]>
MaGonzalMayedo pushed a commit to MaGonzalMayedo/data-prepper that referenced this pull request Jul 25, 2023
@kkondaka
Fix SqsWorker error messages (opensearch-project#2991)
5570194 
Signed-off-by: Krishna Kondaka <[email protected]>
Co-authored-by: Krishna Kondaka <[email protected]>
Signed-off-by: Marcos Gonzalez Mayedo <[email protected]>
@kkondaka kkondaka deleted the s3-sqs-log-messages branch May 13, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asifsmohammed asifsmohammed asifsmohammed approved these changes

@engechas engechas engechas approved these changes

@chenqi0805 chenqi0805 Awaiting requested review from chenqi0805 chenqi0805 is a code owner

@graytaylor0 graytaylor0 Awaiting requested review from graytaylor0 graytaylor0 is a code owner

@dinujoh dinujoh Awaiting requested review from dinujoh dinujoh is a code owner

@cmanning09 cmanning09 Awaiting requested review from cmanning09

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@oeyh oeyh Awaiting requested review from oeyh oeyh is a code owner

Assignees
No one assigned
Labels
backport 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkondaka @asifsmohammed @engechas