-Support for Sink Codecs #2986
Merged
-Support for Sink Codecs #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: umairofficial <[email protected]>
umayr-codes
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed,
dlvenable and
oeyh
as code owners
4 tasks
Signed-off-by: umairofficial <[email protected]>
asuresh8
approved these changes
Jul 10, 2023
Signed-off-by: umairofficial <[email protected]>
Signed-off-by: umairofficial <[email protected]>
Signed-off-by: umairofficial <[email protected]>
Signed-off-by: umairofficial <[email protected]>
Signed-off-by: umairofficial <[email protected]>
Signed-off-by: umairofficial <[email protected]>
# Conflicts: # data-prepper-plugins/parse-json-processor/src/test/java/org/opensearch/dataprepper/plugins/codec/json/JsonOutputCodecTest.java # data-prepper-plugins/parse-json-processor/src/test/java/org/opensearch/dataprepper/plugins/codec/json/NewlineDelimitedOutputCodecTest.java # data-prepper-plugins/s3-sink/build.gradle # data-prepper-plugins/s3-sink/src/integrationTest/java/org/opensearch/dataprepper/plugins/sink/S3SinkServiceIT.java
Signed-off-by: umairofficial <[email protected]>
Signed-off-by: umairofficial <[email protected]>
Signed-off-by: umairofficial <[email protected]>
Signed-off-by: umairofficial <[email protected]>
Signed-off-by: umairofficial <[email protected]>
graytaylor0
approved these changes
Jul 26, 2023
Comment on lines
+34
to
+44
| @Size(max = 0, message = "Schema from file is not supported.") | ||
| @JsonProperty("region") | ||
| private String region; | ||
|
|
||
| @Valid | ||
| @Size(max = 0, message = "Schema from file is not supported.") | ||
| @JsonProperty("bucket_name") | ||
| private String bucketName; | ||
|
|
||
| @Valid | ||
| @Size(max = 0, message = "Schema from file is not supported.") |
There was a problem hiding this comment.
The error messages on these are copied from schema_file_location
There was a problem hiding this comment.
Merging this for now. Please fix this @umayr-codes
There was a problem hiding this comment.
These error messages were written in accordance with Ashok's suggestion!
Comment on lines
+30
to
+38
| @Size(max = 0, message = "Header from file is not supported.") | ||
| @JsonProperty("region") | ||
| private String region; | ||
| @Valid | ||
| @Size(max = 0, message = "Header from file is not supported.") | ||
| @JsonProperty("bucket_name") | ||
| private String bucketName; | ||
| @Valid | ||
| @Size(max = 0, message = "Header from file is not supported.") |
There was a problem hiding this comment.
This error message is copied from header_file_location
There was a problem hiding this comment.
Merging this for now. Please fix this @umayr-codes
There was a problem hiding this comment.
These error messages were written in accordance with Ashok's suggestion!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: umairofficial [email protected]
Description
AvroSinkCodec,JsonSinkCodec&CsvSinkCodecimplementation addedconfigclasses for the respective sink codecs addedInputCodecsaddedS3SinkaddedReadme.mdfiles updatedIssues Resolved
Resolves #2403
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.