Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc bug fixes and minor UX improvements II #432

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Oct 18, 2024

Description

Continuation of #427 . Changes:

  • readonly views of the docs & query inputs are EuiCodeBlock
  • rename "Tools" to "Inspector"
  • remove workflow state in header of details page
  • make the right-side panel (the preview + tools panels) collapsible, instead of the workflow inputs, since workflow inputs is the primary space users will be interacting with
  • capitalize "PROCESSORS" when selecting a processor in ingest/search pipeline form inputs
  • cleans up some spacing issue due to Fit and Finish enhancements #428
  • moves edit import data into header
  • moves edit query / test query into header
  • tune wording & simplify layout of the input/output transform form components (MapArrayField / MapField)

Demo video highlighting changes:

screen-capture.11.webm

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler ohltyler added bug Something isn't working enhancement New feature or request backport 2.x labels Oct 18, 2024
@ohltyler ohltyler marked this pull request as draft October 18, 2024 19:12
@ohltyler ohltyler marked this pull request as ready for review October 18, 2024 23:20
Signed-off-by: Tyler Ohlsen <[email protected]>
Copy link
Collaborator

@saimedhi saimedhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ohltyler ,

  • Looks good to me.
  • Could you please merge integration test workflow. So, that integration tests start running on PRs.Added Integration Tests Workflow #426
  • With the changes in this PR, I'll make the necessary updates to the integration test specs in the Functional Test repo. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants