Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Enable Flattened custom result index checkbox #830

Merged

Conversation

jackiehanyang
Copy link
Collaborator

@jackiehanyang jackiehanyang commented Aug 5, 2024

Description

Add Enable Flattened custom result index checkbox to allow customer to enable this feature

Screen.Recording.2024-08-05.at.15.49.35.mov

Screenshot 2024-08-06 at 11 30 12

Issues Resolved

opensearch-project/anomaly-detection#1213

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Jackie Han <[email protected]>
@kaituo
Copy link
Collaborator

kaituo commented Aug 6, 2024

Looks good. Wait for CI to pass.

@jackiehanyang
Copy link
Collaborator Author

Looks good. Wait for CI to pass.

2 tests that are not related to my change failed for my previous commit because of this error:

FAIL public/expressions/__tests__/overlay_anomalies.test.ts
  ● Test suite failed to run

    Cannot find module '!!raw-loader!../../target/public/xjson.editor.worker.js' from '../../packages/osd-monaco/target/xjson/language.js'

They might fail again in the current run. Will monitoring it

@jackiehanyang
Copy link
Collaborator Author

UT CI failed due to same unrelated issue. Working with OSD team about this issue...

Summary of all failing tests
FAIL public/components/FeatureAnywhereContextMenu/AssociatedDetectors/containers/__tests__/AssociatedDetectors.test.tsx
  ● Test suite failed to run

    Cannot find module '!!raw-loader!../../target/public/xjson.editor.worker.js' from '../../packages/osd-monaco/target/xjson/language.js'
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

    Require stack:
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/packages/osd-monaco/target/xjson/language.js
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/packages/osd-monaco/target/xjson/index.js
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/packages/osd-monaco/target/index.js
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/data/public/antlr/opensearch_sql/code_completion.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/data/public/plugin.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/data/public/index.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/saved_objects/public/saved_object/helpers/serialize_saved_object.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/saved_objects/public/saved_object/helpers/build_saved_object.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/saved_objects/public/saved_object/saved_object.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/saved_objects/public/saved_object/index.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/saved_objects/public/plugin.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/saved_objects/public/index.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/vis_augmenter/public/saved_augment_vis/saved_augment_vis.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/vis_augmenter/public/saved_augment_vis/index.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/vis_augmenter/public/plugin.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/vis_augmenter/public/index.ts
      public/components/FeatureAnywhereContextMenu/AssociatedDetectors/containers/AssociatedDetectors.tsx
      public/components/FeatureAnywhereContextMenu/AssociatedDetectors/containers/__tests__/AssociatedDetectors.test.tsx

      37 | import { registerWorker } from '../worker_store';
      38 | // @ts-ignore
    > 39 | import workerSrc from '!!raw-loader!../../target/public/xjson.editor.worker.js';
         | ^
      40 |
      41 | const wps = new WorkerProxyService();
      42 |

      at Resolver.resolveModule (../../node_modules/jest-resolve/build/resolver.js:324:11)
      at Object.<anonymous> (../../packages/osd-monaco/src/xjson/language.ts:39:1)
      at Object.<anonymous> (../../packages/osd-monaco/src/xjson/index.ts:34:1)
      at Object.<anonymous> (../../packages/osd-monaco/src/index.ts:32:1)
      at Object.<anonymous> (../../src/plugins/data/public/antlr/opensearch_sql/code_completion.ts:6:1)
      at Object.<anonymous> (../../src/plugins/data/public/plugin.ts:96:1)
      at Object.<anonymous> (../../src/plugins/data/public/index.ts:500:1)
      at Object.<anonymous> (../../src/plugins/saved_objects/public/saved_object/helpers/serialize_saved_object.ts:34:1)
      at Object.<anonymous> (../../src/plugins/saved_objects/public/saved_object/helpers/build_saved_object.ts:34:1)
      at Object.<anonymous> (../../src/plugins/saved_objects/public/saved_object/saved_object.ts:42:1)

FAIL public/expressions/__tests__/overlay_anomalies.test.ts
  ● Test suite failed to run

    Cannot find module '!!raw-loader!../../target/public/xjson.editor.worker.js' from '../../packages/osd-monaco/target/xjson/language.js'

    Require stack:
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/packages/osd-monaco/target/xjson/language.js
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/packages/osd-monaco/target/xjson/index.js
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/packages/osd-monaco/target/index.js
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/data/public/antlr/opensearch_sql/code_completion.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/data/public/plugin.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/data/public/index.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/saved_objects/public/saved_object/helpers/serialize_saved_object.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/saved_objects/public/saved_object/helpers/build_saved_object.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/saved_objects/public/saved_object/saved_object.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/saved_objects/public/saved_object/index.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/saved_objects/public/plugin.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/saved_objects/public/index.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/vis_augmenter/public/saved_augment_vis/saved_augment_vis.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/vis_augmenter/public/saved_augment_vis/index.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/vis_augmenter/public/plugin.ts
      /Users/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/src/plugins/vis_augmenter/public/index.ts
      public/expressions/helpers.ts
      public/expressions/__tests__/overlay_anomalies.test.ts

      37 | import { registerWorker } from '../worker_store';
      38 | // @ts-ignore
    > 39 | import workerSrc from '!!raw-loader!../../target/public/xjson.editor.worker.js';
         | ^
      40 |
      41 | const wps = new WorkerProxyService();
      42 |

      at Resolver.resolveModule (../../node_modules/jest-resolve/build/resolver.js:324:11)
      at Object.<anonymous> (../../packages/osd-monaco/src/xjson/language.ts:39:1)
      at Object.<anonymous> (../../packages/osd-monaco/src/xjson/index.ts:34:1)
      at Object.<anonymous> (../../packages/osd-monaco/src/index.ts:32:1)
      at Object.<anonymous> (../../src/plugins/data/public/antlr/opensearch_sql/code_completion.ts:6:1)
      at Object.<anonymous> (../../src/plugins/data/public/plugin.ts:96:1)
      at Object.<anonymous> (../../src/plugins/data/public/index.ts:500:1)
      at Object.<anonymous> (../../src/plugins/saved_objects/public/saved_object/helpers/serialize_saved_object.ts:34:1)
      at Object.<anonymous> (../../src/plugins/saved_objects/public/saved_object/helpers/build_saved_object.ts:34:1)
      at Object.<anonymous> (../../src/plugins/saved_objects/public/saved_object/saved_object.ts:42:1)


Test Suites: 2 failed, 1 skipped, 77 passed, 79 of 80 total
Tests:       2 skipped, 371 passed, 373 total
Snapshots:   71 passed, 71 total
Time:        175.192 s
Ran all test suites.
error Command failed with exit code 1.
Error: Process completed with exit code 1.

@jackiehanyang
Copy link
Collaborator Author

tracking the failing ut issue here - #832

@jackiehanyang jackiehanyang merged commit d220c73 into opensearch-project:main Aug 7, 2024
6 of 9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 7, 2024
* Add Enable Flattened custom result index checkbox

Signed-off-by: Jackie Han <[email protected]>

* add hint text

Signed-off-by: Jackie Han <[email protected]>

---------

Signed-off-by: Jackie Han <[email protected]>
(cherry picked from commit d220c73)
jackiehanyang added a commit that referenced this pull request Aug 7, 2024
* Add Enable Flattened custom result index checkbox

Signed-off-by: Jackie Han <[email protected]>

* add hint text

Signed-off-by: Jackie Han <[email protected]>

---------

Signed-off-by: Jackie Han <[email protected]>
(cherry picked from commit d220c73)

Co-authored-by: Jackie Han <[email protected]>
jackiehanyang added a commit to jackiehanyang/anomaly-detection-dashboards-plugin that referenced this pull request Sep 3, 2024
jackiehanyang added a commit to jackiehanyang/anomaly-detection-dashboards-plugin that referenced this pull request Sep 3, 2024
jackiehanyang added a commit that referenced this pull request Sep 3, 2024
…" (#862)

* Revert "Add Enable Flattened custom result index checkbox (#830) (#833)"

This reverts commit f53450c.

* update snapshot

Signed-off-by: Jackie Han <[email protected]>

---------

Signed-off-by: Jackie Han <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants