Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Home] Add support for otel sample data - logs, traces and metrics #8666

Merged
merged 1 commit into from
Oct 19, 2024
Merged

[Backport 2.x] [Home] Add support for otel sample data - logs, traces and metrics #8666

merged 1 commit into from
Oct 19, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport c8b5318 from #8587.

@github-actions @opensearch-changeset-bot
@mengweieric @RyanL1997
[WIP] Add support for otel sample data - logs, traces and metrics (#8587
fddbda2 
)

* add support for otel sample data - traces and services

Signed-off-by: Shenoy Pratik <[email protected]>

* Changeset file for PR #8587 created/updated

* upload gz otel data

Signed-off-by: Eric <[email protected]>

* add mappings

Signed-off-by: Eric <[email protected]>

* correct mappings

Signed-off-by: Eric <[email protected]>

* Fix the time mismatch for otel sample data

Signed-off-by: Ryan Liang <[email protected]>

* adjust time maker

Signed-off-by: Eric <[email protected]>

* create index name tests

Signed-off-by: Eric <[email protected]>

* add indexName field to DataIndexSchema, move nested field functions to utils

Signed-off-by: Shenoy Pratik <[email protected]>

* add button for app redirection, resolve comments

Signed-off-by: Shenoy Pratik <[email protected]>

* adjust id field to be as keyword

Signed-off-by: Eric <[email protected]>

* remove redundant keyword declaration

Signed-off-by: Eric <[email protected]>

* move to use correct format sample suffix

Signed-off-by: Eric <[email protected]>

* update text and one log index name/id

Signed-off-by: Eric <[email protected]>

* fix sample data test

Signed-off-by: Eric <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Eric <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Eric Wei <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Eric <[email protected]>
Co-authored-by: Ryan Liang <[email protected]>
(cherry picked from commit c8b5318)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added autocut Skip the changelog verification check on backports repeat-contributor labels Oct 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Oct 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.17073% with 11 lines in your changes missing coverage. Please review.

Project coverage is 60.96%. Comparing base (dff25a9) to head (fddbda2).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ns/home/server/services/sample_data/routes/list.ts 33.33% 5 Missing and 3 partials ⚠️
...ication/components/sample_data_view_data_button.js 87.50% 1 Missing ⚠️
...home/server/services/sample_data/data_sets/util.ts 93.33% 0 Missing and 1 partial ⚠️
...home/server/services/sample_data/routes/install.ts 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              2.x    #8666   +/-   ##
=======================================
  Coverage   60.95%   60.96%           
=======================================
  Files        3786     3786           
  Lines       90212    90237   +25     
  Branches    14126    14136   +10     
=======================================
+ Hits        54988    55010   +22     
  Misses      31758    31758           
- Partials     3466     3469    +3
Flag Coverage Δ
Linux_1 29.13% <ø> (ø)
Linux_2 56.53% <ø> (ø)
Linux_3 37.74% <ø> (ø)
Linux_4 30.05% <73.17%> (+0.02%) ⬆️
Windows_1 29.14% <ø> (ø)
Windows_2 56.49% <ø> (ø)
Windows_3 37.74% <ø> (ø)
Windows_4 30.05% <73.17%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mengweieric mengweieric merged commit 1995d7d into 2.x Oct 19, 2024
67 of 69 checks passed
@github-actions github-actions bot deleted the backport/backport-8587-to-2.x branch October 19, 2024 04:56
@mengweieric mengweieric changed the title [Backport 2.x] [WIP] Add support for otel sample data - logs, traces and metrics [Backport 2.x] [Home] Add support for otel sample data - logs, traces and metrics Oct 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuali925 joshuali925 joshuali925 approved these changes

@mengweieric mengweieric mengweieric approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports failed changeset repeat-contributor v2.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuali925 @mengweieric @ashwin-pc