Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Manual backport 2.x] Improve Empty State Handling: Add No Index Patterns Panel with Data Selection in Discover View #8613 #8662

Closed
wants to merge 2 commits into from
Closed

[Manual backport 2.x] Improve Empty State Handling: Add No Index Patterns Panel with Data Selection in Discover View #8613 #8662

wants to merge 2 commits into from

Commits on Oct 19, 2024

  1. Update Discover appearance (opensearch-project#8651) 

    * Update Discover appearance

Signed-off-by: Miki <[email protected]>

* Changeset file for PR opensearch-project#8651 created/updated

---------

Signed-off-by: Miki <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

(cherry picked from commit 17103ba)
Signed-off-by: Miki <[email protected]>
    @AMoo-Miki @opensearch-changeset-bot
    AMoo-Miki and opensearch-changeset-bot[bot] committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    fdf337d View commit details
    Browse the repository at this point in the history

  2. Improve Empty State Handling: Add No Index Patterns Panel with Data S… 

    …election in Discover View (opensearch-project#8613)

* Improve Empty State Handling: Add No Index Patterns Panel with Data Selection in Discover View

This PR primarily addresses the scenario when no index patterns (general) is available in the Discover view.
Instead of redirecting users to the index management page, it introduces a new "No Index Patterns" panel.
This panel provides users with the option to open a data selector and add index patterns
directly from the Discover view, improving the user experience for new or empty deployments.

To achieve, we move the selectedDataset state from ConnectedDatasetSelector to the app container's
state management. This allows the AdvancedSelector, opened from the AppContainer, to update
the dataset state effectively. Key changes include:

* Implementing NoIndexPatternsPanel and AdvancedSelector components.
* Refactoring dataset state management in AppContainer and Sidebar.
* Modifying DiscoverCanvas to conditionally render NoIndexPatternsPanel.
* Updating ConnectedDatasetSelector to use shared state and dataset change handling.

Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: Miki <[email protected]>

* Update design of no data selected

Signed-off-by: Miki <[email protected]>

* use i18n

Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: Miki <[email protected]>

* fix comments

Signed-off-by: Anan Zhuang <[email protected]>

* Update design of no data selected

Signed-off-by: Miki <[email protected]>

* fix lint error

Signed-off-by: Anan Zhuang <[email protected]>

---------

Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: Miki <[email protected]>
Co-authored-by: Miki <[email protected]>

(cherry picked from commit 6659139)
Signed-off-by: Miki <[email protected]>
    @ananzh @AMoo-Miki
    ananzh and AMoo-Miki committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    de2f5f6 View commit details
    Browse the repository at this point in the history