Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] update search bar layout and align workspace selector #8649

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented Oct 18, 2024

Description

  1. Adjust workspace selector to align with left nav items
  2. Let search bar popup when click on it
  3. Use normal font weight for search items text

Issues Resolved

Screenshot

searchbar.mov

Testing the changes

  1. enable workspace and new homepage by putting this into yml
workspace.enabled: true
uiSettings:
  overrides:
    "home:useNewHomePage": true
  1. start OSD yarn start

Changelog

  • fix: finetune search bar and workspace selector style

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

opensearch-changeset-bot bot added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Oct 18, 2024
@Hailong-am Hailong-am changed the title [workspace] update search bar layout [workspace] update search bar layout and align workspace selector Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

Project coverage is 60.84%. Comparing base (c8b5318) to head (54eb759).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...core/public/chrome/ui/header/header_search_bar.tsx 89.47% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8649   +/-   ##
=======================================
  Coverage   60.83%   60.84%           
=======================================
  Files        3793     3793           
  Lines       90412    90409    -3     
  Branches    14196    14197    +1     
=======================================
+ Hits        55002    55007    +5     
+ Misses      31933    31927    -6     
+ Partials     3477     3475    -2     
Flag Coverage Δ
Linux_1 29.08% <0.00%> (+<0.01%) ⬆️
Linux_2 56.41% <89.47%> (+0.01%) ⬆️
Linux_3 37.67% <0.00%> (+<0.01%) ⬆️
Linux_4 29.82% <0.00%> (+<0.01%) ⬆️
Windows_1 29.09% <0.00%> (+<0.01%) ⬆️
Windows_2 56.36% <89.47%> (+0.01%) ⬆️
Windows_3 37.67% <0.00%> (+<0.01%) ⬆️
Windows_4 29.82% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant