Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Refactor workspace detail page #8615

Merged

Conversation

yubonluo
Copy link
Contributor

Description

Refactor workspace detail page

  1. Delete Collaborators and Data source tab at workspace detail page
  2. Delete owners at the panel of workspace detail page
  3. Click workspace name at workspace list page will navigate to use case overview page
  4. Click data source more badge at workspace list page will navigate data source page
  5. Creating workspace successfully will navigate to Collaborators page
  6. Optimize the file structure and delete useless code

Issues Resolved

N/A

Screenshot

image

Testing the changes

Changelog

  • refactor: Refactor workspace detail page

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yubonluo yubonluo force-pushed the 2.17/reafactor-workspace-detail branch from acd1df4 to ee4e8fb Compare October 17, 2024 09:20
SuZhou-Joe
SuZhou-Joe previously approved these changes Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 65.62500% with 11 lines in your changes missing coverage. Please review.

Project coverage is 60.87%. Comparing base (4a2416f) to head (884cf44).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...c/components/workspace_detail/workspace_detail.tsx 66.66% 3 Missing and 1 partial ⚠️
...rkspace/public/components/workspace_list/index.tsx 50.00% 1 Missing and 3 partials ⚠️
...ponents/workspace_detail/workspace_detail_form.tsx 75.00% 1 Missing and 1 partial ⚠️
src/plugins/workspace/public/plugin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8615      +/-   ##
==========================================
- Coverage   60.95%   60.87%   -0.08%     
==========================================
  Files        3792     3790       -2     
  Lines       90355    90211     -144     
  Branches    14170    14141      -29     
==========================================
- Hits        55072    54915     -157     
- Misses      31822    31834      +12     
- Partials     3461     3462       +1     
Flag Coverage Δ
Linux_1 29.16% <65.62%> (-0.17%) ⬇️
Linux_2 56.39% <ø> (ø)
Linux_3 37.71% <ø> (+<0.01%) ⬆️
Linux_4 29.91% <ø> (ø)
Windows_1 29.18% <65.62%> (-0.17%) ⬇️
Windows_2 56.34% <ø> (ø)
Windows_3 37.71% <ø> (-0.01%) ⬇️
Windows_4 29.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: yubonluo <[email protected]>
@SuZhou-Joe SuZhou-Joe merged commit 436e946 into opensearch-project:main Oct 17, 2024
66 of 68 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8615-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 436e9462c7edc7ba168191051719d487cbbbb088
# Push it to GitHub
git push --set-upstream origin backport/backport-8615-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8615-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 17, 2024
* refactor workspace detail page

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* fix test errors

Signed-off-by: yubonluo <[email protected]>

---------

Signed-off-by: yubonluo <[email protected]>
(cherry picked from commit 436e946)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Oct 17, 2024
* refactor workspace detail page



* optimize the code



* fix test errors



---------


(cherry picked from commit 436e946)

Signed-off-by: yubonluo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/OpenSearch-Dashboards that referenced this pull request Oct 19, 2024
* refactor workspace detail page

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* fix test errors

Signed-off-by: yubonluo <[email protected]>

---------

Signed-off-by: yubonluo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants