-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Refactor workspace detail page #8615
[Workspace] Refactor workspace detail page #8615
Conversation
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
acd1df4
to
ee4e8fb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8615 +/- ##
==========================================
- Coverage 60.95% 60.87% -0.08%
==========================================
Files 3792 3790 -2
Lines 90355 90211 -144
Branches 14170 14141 -29
==========================================
- Hits 55072 54915 -157
- Misses 31822 31834 +12
- Partials 3461 3462 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: yubonluo <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8615-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 436e9462c7edc7ba168191051719d487cbbbb088
# Push it to GitHub
git push --set-upstream origin backport/backport-8615-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
* refactor workspace detail page Signed-off-by: yubonluo <[email protected]> * optimize the code Signed-off-by: yubonluo <[email protected]> * fix test errors Signed-off-by: yubonluo <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> (cherry picked from commit 436e946) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* refactor workspace detail page * optimize the code * fix test errors --------- (cherry picked from commit 436e946) Signed-off-by: yubonluo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* refactor workspace detail page Signed-off-by: yubonluo <[email protected]> * optimize the code Signed-off-by: yubonluo <[email protected]> * fix test errors Signed-off-by: yubonluo <[email protected]> --------- Signed-off-by: yubonluo <[email protected]>
Description
Refactor workspace detail page
Issues Resolved
N/A
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration