Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump cookie to 0.7.2 #8599

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joshuali925
Copy link
Member

Description

bump cookie to ^0.7.0 for CVE-2024-47764. Although elastic-apm-node depends on cookie@^0.5.0, 0 seems to be a special major version and yarn refuses to have 0.7.2 under ^0.5.0. Based on their releases https://github.com/jshttp/cookie/releases, there are no breaking change introduced in between

The other option is to use elastic-apm-node v4

Issues Resolved

#8515

Screenshot

Testing the changes

Changelog

  • fix: bump cookie to 0.7.2

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Joshua Li <[email protected]>
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.94%. Comparing base (47ae28b) to head (aa3e7e1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8599      +/-   ##
==========================================
- Coverage   60.95%   60.94%   -0.01%     
==========================================
  Files        3790     3790              
  Lines       90296    90296              
  Branches    14151    14151              
==========================================
- Hits        55036    55034       -2     
- Misses      31804    31805       +1     
- Partials     3456     3457       +1     
Flag Coverage Δ
Linux_1 29.29% <ø> (ø)
Linux_2 56.39% <ø> (ø)
Linux_3 37.72% <ø> (ø)
Linux_4 29.91% <ø> (ø)
Windows_1 29.31% <ø> (ø)
Windows_2 56.34% <ø> (ø)
Windows_3 37.72% <ø> (-0.01%) ⬇️
Windows_4 29.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant