[Backport 2.8] Fix Node.js download link #4570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
https://mirrors.nodejs.org/ is no longer available which prevents the ability from release builds being made. Restoring back the original link. Follow-up should be considered about a caching mechanism and param to the CLI to utilize another link or path. Signed-off-by: Miki <[email protected]> (cherry picked from commit d746595) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki and
ashwin-pc
as code owners
opensearch-trigger-bot
bot
added
the
autocut
opensearch-trigger-bot
bot
requested review from
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu and
manasvinibs
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.8 #4570 +/- ##
=======================================
Coverage 66.35% 66.35%
=======================================
Files 3229 3229
Lines 62093 62093
Branches 9612 9612
=======================================
Hits 41202 41202
Misses 18571 18571
Partials 2320 2320
Flags with carried forward coverage won't be shown. Click here to find out more.
|
manasvinibs
approved these changes
Jul 13, 2023
AMoo-Miki
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport d746595 from #4556.