Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump stylelint from 14.6.1 to 15.10.1 #4523

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 7, 2023

Bumps stylelint from 14.6.1 to 15.10.1.

Release notes

Sourced from stylelint's releases.

15.10.1

15.10.0

15.9.0

  • Added: insideFunctions: {"function": int} to number-max-precision (#6932) (@​romainmenke).
  • Fixed: declaration-block-no-redundant-longhand-properties autofix for border-radius shorthand (#6958) (@​mattxwang).
  • Fixed: declaration-block-no-redundant-longhand-properties autofix for border-width shorthand (#6956) (@​mattxwang).
  • Fixed: declaration-block-no-redundant-longhand-properties autofix for grid-column and grid-row (#6957) (@​mattxwang).

15.8.0

15.7.0

  • Added: splitList: boolean to selector-nested-pattern (#6896) (@​is2ei).
  • Fixed: unit-no-unknown false positives for unicode-range descriptors (#6892) (@​romainmenke).

... (truncated)

Changelog

Sourced from stylelint's changelog.

15.10.1

15.10.0

15.9.0

  • Added: insideFunctions: {"function": int} to number-max-precision (#6932) (@​romainmenke).
  • Fixed: declaration-block-no-redundant-longhand-properties autofix for border-radius shorthand (#6958) (@​mattxwang).
  • Fixed: declaration-block-no-redundant-longhand-properties autofix for border-width shorthand (#6956) (@​mattxwang).
  • Fixed: declaration-block-no-redundant-longhand-properties autofix for grid-column and grid-row (#6957) (@​mattxwang).

15.8.0

... (truncated)

Commits
Maintainer changes

This version was pushed to npm by mattxwang, a new releaser for stylelint since your current version.


Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #4523 (656f9a9) into main (24bde32) will decrease coverage by 0.03%.
Report is 108 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4523      +/-   ##
==========================================
- Coverage   66.54%   66.51%   -0.03%     
==========================================
  Files        3288     3409     +121     
  Lines       63347    67260    +3913     
  Branches     9844    10772     +928     
==========================================
+ Hits        42154    44739    +2585     
- Misses      18758    19908    +1150     
- Partials     2435     2613     +178     
Flag Coverage Δ
Linux_1 ?
Linux_2 55.78% <ø> (+0.74%) ⬆️
Linux_3 44.71% <ø> (+1.08%) ⬆️
Linux_4 34.79% <ø> (-1.07%) ⬇️
Windows_1 34.58% <ø> (-0.80%) ⬇️
Windows_2 55.75% <ø> (+0.74%) ⬆️
Windows_3 44.71% <ø> (+1.08%) ⬆️
Windows_4 34.79% <ø> (-1.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 236 files with indirect coverage changes

@joshuarrrr
Copy link
Member

@AMoo-Miki Assigning to you as part of oncall-handoff. Looks like we'll need to figure out why this version seems to have build issues.

@kavilla
Copy link
Member

kavilla commented Sep 25, 2023

@AMoo-Miki Assigning to you as part of oncall-handoff. Looks like we'll need to figure out why this version seems to have build issues.

Haven't checked, but I believe stylelint is default called a lot and likely could be we need to modify our stylelint to make sure it's configured correctly on the major version bump

cc: @abbyhu2000

@AMoo-Miki
Copy link
Collaborator

AMoo-Miki commented Oct 2, 2023

There is a whole migration guide for this major version bump that has a bunch of breaking changes.

@AMoo-Miki
Copy link
Collaborator

AMoo-Miki commented Oct 2, 2023

postcss did a major bump of their typescript and when making a patch release of 8.4.22. stylelint has a dep on postcss@^8.4.24 but I see no specific reason for their dep on that specific range; in fact, it appears that stylelint simply bumps deps for no reasons.

I have clamped down stylelint/postcss to 8.4.21.

Bumps [stylelint](https://github.com/stylelint/stylelint) from 14.6.1 to 15.10.1.
- [Release notes](https://github.com/stylelint/stylelint/releases)
- [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md)
- [Commits](stylelint/stylelint@14.6.1...15.10.1)

---
updated-dependencies:
- dependency-name: stylelint
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Miki <[email protected]>
@AMoo-Miki AMoo-Miki force-pushed the dependabot/npm_and_yarn/stylelint-15.10.1 branch from b746fa2 to 656f9a9 Compare October 2, 2023 23:29
@AMoo-Miki AMoo-Miki requested a review from curq as a code owner October 2, 2023 23:29
@AMoo-Miki AMoo-Miki added the autocut Skip the changelog verification check on backports label Oct 2, 2023
@joshuarrrr
Copy link
Member

@AMoo-Miki A couple linting errors for unresolved imports.

@AMoo-Miki
Copy link
Collaborator

[email protected] introduced braking changes and we cannot upgrade to a version above 15.10.0. We have dealt with the semver vulnerability by adding a resolution:

"**/semver": "^7.5.3",

@AMoo-Miki AMoo-Miki closed this Oct 3, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 3, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/stylelint-15.10.1 branch October 3, 2023 17:33
@AMoo-Miki
Copy link
Collaborator

@dependabot ignore this major version

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 4, 2023

OK, I won't notify you about version 15.x.x again, unless you re-open this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor autocut Skip the changelog verification check on backports dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants