Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/remove breadcrumb styling #4341

Conversation

joshuarrrr
Copy link
Member

Description

This removes much of the breadcrumb customization required prior to the establishment of OUI, now that breadcrumb styles have been updated over there.

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Now that the breacrumb styling is coming from OUI

Signed-off-by: Josh Romero <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
@@ -114,7 +114,7 @@ export function Header({
const toggleCollapsibleNavRef = createRef<HTMLButtonElement & { euiAnimate: () => void }>();
const navId = htmlIdGenerator()();
const className = classnames('hide-for-sharing', 'headerGlobalNav');
const { useExpandedHeader = true, darkMode } = branding;
const { useExpandedHeader = true } = branding;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean now breadcrumbs cannot be customized theme specific and is inherited as it is from oui?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, breadcrumbs in OpenSearch Dashboards were never intended to be customized/customizable, we just had to do things that way because OUI was not yet available. But OUI should be responsible for the styling and theming of the breadcrumb components.

Copy link
Collaborator

@AMoo-Miki AMoo-Miki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #4341 (3b1be90) into feature/oui-re-theme (fe1f1d1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@                  Coverage Diff                  @@
##           feature/oui-re-theme    #4341   +/-   ##
=====================================================
  Coverage                 66.41%   66.41%           
=====================================================
  Files                      3246     3246           
  Lines                     62466    62465    -1     
  Branches                   9674     9673    -1     
=====================================================
  Hits                      41485    41485           
- Misses                    18606    18633   +27     
+ Partials                   2375     2347   -28     
Flag Coverage Δ
Linux 66.36% <100.00%> (+<0.01%) ⬆️
Windows 66.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/public/chrome/ui/header/header.tsx 73.33% <100.00%> (ø)
...ore/public/chrome/ui/header/header_breadcrumbs.tsx 100.00% <100.00%> (+10.00%) ⬆️

... and 11 files with indirect coverage changes

@joshuarrrr joshuarrrr merged commit 1de54d7 into opensearch-project:feature/oui-re-theme Jul 13, 2023
@joshuarrrr joshuarrrr deleted the refactor/remove-breadcrumb-styling branch July 13, 2023 20:26
@opensearch-trigger-bot
Copy link
Contributor

The backport to main failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-main main
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-main
# Create a new branch
git switch --create backport/backport-4341-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1de54d72f229bee57f7dcb82d38ad16cf1f2987f
# Push it to GitHub
git push --set-upstream origin backport/backport-4341-to-main
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-4341-to-main.

@joshuarrrr
Copy link
Member Author

backport didn't work - I'll just manually cherry-pick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants