Adding image filter, xslt filter, and geo ip as dynamic modules #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, and xslt filter module
…e, and xslt filter module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested builds on the vagrant boxes edrw/centos7-64 and ubuntu/trusty64.
I updated the rpm changelog to include a note about the update. I assumed this would be version
1.13.6.2-2of the package. Did not update the deb changelog since I saw debuild asks for the key of the user who last edited the changelog so I figure that should be OpenResty Admin.Encountered an issue with debuild trying to sign the package after building it and blowing up because the secret key was not available. I added the args
-uc -usto the debuild command to prevent it from attempting to sign the package. Noticed that currently the package is signed in a separate step that is kept commented out. Would you like me to add that change to the branch or submit a separate PR so deb builds will work for other contributors without having to edit the Makefile?This is my first time messing with packaging, let me know if you see any issues that need to be addressed.