Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug in generate_data and adapted tests #29

Merged
merged 9 commits into from
Jun 6, 2024

Conversation

kuenzelt
Copy link
Collaborator

@kuenzelt kuenzelt commented May 17, 2024

closes #28

@kuenzelt kuenzelt self-assigned this May 17, 2024
@kuenzelt kuenzelt linked an issue May 17, 2024 that may be closed by this pull request
4 tasks
Copy link
Contributor

github-actions bot commented May 17, 2024

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ---------
R/aalen_johansen.R               62       0  100.00%
R/assert.R                        5       0  100.00%
R/generate_data.R                36       0  100.00%
R/inc_prop.R                      7       0  100.00%
R/one_minus_kaplan_meier.R       21       0  100.00%
R/prop_trans_inc_dens_ce.R       23       0  100.00%
R/prop_trans_inc_dens.R          10       0  100.00%
TOTAL                           164       0  100.00%

Diff against main

Filename             Stmts    Miss  Cover
-----------------  -------  ------  --------
R/generate_data.R       +9       0  +100.00%
TOTAL                   +9       0  +100.00%

Results for commit: b8b9db0

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@danielinteractive
Copy link
Collaborator

Thanks @kuenzelt for working on this, can you please add a test that can show that there is this bug? Meaning, if you execute that particular test, it will fail with the current version of the package.

Copy link
Contributor

github-actions bot commented May 17, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
generate_data 👶 $+0.26$ generate_data_correctly_..._

Results for commit 3f1df3b

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, plus we need the NEWS entry

Copy link
Contributor

github-actions bot commented Jun 5, 2024

Unit Tests Summary

 1 files   7 suites   1s ⏱️
13 tests 13 ✅ 0 💤 0 ❌
20 runs  20 ✅ 0 💤 0 ❌

Results for commit b8b9db0.

♻️ This comment has been updated with latest results.

NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kuenzelt , I just did some last touches (version update, minor polishing on the NEWS). Good to merge as soon checks pass, and then you can build the package and submit to CRAN. Please let me know if you have any questions

@danielinteractive danielinteractive merged commit 904eebf into main Jun 6, 2024
24 checks passed
@danielinteractive danielinteractive deleted the 28-bug-in-generate_data branch June 6, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in generate_data()
2 participants