fix(test): set log location in tests

openlawlibrary · Oct 29, 2023 · 8d4d28e · 8d4d28e
1 parent 7278238
commit 8d4d28e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/upgrade/scripts/manage_venv.py b/upgrade/scripts/manage_venv.py
@@ -114,7 +114,7 @@ def upgrade_venv(
             if is_development_cloudsmith(cloudsmith_url):
                 upgrade_args.append("'--pre'")
             else:
-                upgrade_args.append(f'--version="{requirements_obj.specifier}"')
+                upgrade_args.append(f"--version={str(requirements_obj.specifier)}")
 
             if log_location:
                 upgrade_args.append(f"--log-location={log_location}")

diff --git a/upgrade/tests/manage_venv/test_build_and_upgrade_existing_venv.py b/upgrade/tests/manage_venv/test_build_and_upgrade_existing_venv.py
@@ -18,9 +18,11 @@ def test_build_and_upgrade_venv_where_v2_0_0_venv_exists_and_auto_upgrade_is_ena
         dependency_to_install,
         envs_home,
         auto_upgrade=True,
-        cloudsmith_url="",
+        cloudsmith_url="cloudsmith_url",
         wheels_path=str(wheels_dir),
         update_from_local_wheels=True,
+        blue_green_deployment=False,
+        log_location=Path(envs_home, "manage_venv.log"),
     )
 
     venv_path = Path(envs_home, dependency_to_install)
@@ -57,9 +59,10 @@ def test_build_and_upgrade_venv_where_v2_0_1_venv_exists_and_auto_upgrade_is_dis
         dependency_to_install,
         envs_home,
         auto_upgrade=False,
-        cloudsmith_url="",
+        cloudsmith_url="cloudsmith_url",
         wheels_path=str(wheels_dir),
         update_from_local_wheels=True,
+        log_location=Path(envs_home, "manage_venv.log"),
     )
     out, _ = capfd.readouterr()
 
@@ -83,6 +86,7 @@ def test_build_and_upgrade_venv_where_v2_0_1_venv_exists_and_auto_upgrade_is_ena
         cloudsmith_url="cloudsmith_url",
         wheels_path=str(wheels_dir),
         update_from_local_wheels=True,
+        log_location=Path(envs_home, "manage_venv.log"),
     )
 
     venv_path = Path(envs_home, dependency_to_install)

diff --git a/upgrade/tests/manage_venv/test_build_and_upgrade_new_venv.py b/upgrade/tests/manage_venv/test_build_and_upgrade_new_venv.py
@@ -38,6 +38,8 @@ def test_build_and_upgrade_venv_where_venv_did_not_exist_and_auto_upgrade_is_dis
         cloudsmith_url="cloudsmith_url",
         wheels_path=str(wheels_dir),
         update_from_local_wheels=True,
+        blue_green_deployment=False,
+        log_location=Path(envs_home, "manage_venv.log"),
     )
     venv_path = Path(envs_home, dependency_to_install)