-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8323571: Regression in source resolution process #17377
Conversation
👋 Welcome back joehw! A progress list of the required criteria for merging this PR into |
@JoeWang-Java The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
@JoeWang-Java This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 66 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If the file was modified this year, put 2024 in the header
Copyright year fixed. Thanks. |
/integrate |
Going to push as commit e4389d8.
Your commit was automatically rebased without conflicts. |
@JoeWang-Java Pushed as commit e4389d8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Fix a regression in the source resolution process where it failed to recognize a custom InputSource when both the public and system IDs are null. The particular issue is fixed at line 1233, the rest of the changes is formatting to make the null-check on InputSource the first.
Test is provided by Marc, thanks Marc! (junit-team/junit5#3594)
XML tests, including the new test, pass with this change.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17377/head:pull/17377
$ git checkout pull/17377
Update a local copy of the PR:
$ git checkout pull/17377
$ git pull https://git.openjdk.org/jdk.git pull/17377/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17377
View PR using the GUI difftool:
$ git pr show -t 17377
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17377.diff
Webrev
Link to Webrev Comment