Update examples to reference the W3C VCDM v2, Data Integrity, and VC JOSE COSE #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decentralgabe
requested review from
David-Chadwick,
jogu,
selfissued,
Sakurann and
awoie
and removed request for
David-Chadwick
OR13
approved these changes
Oct 25, 2024
msporny
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Overall, LGTM.
Non-blocking feedback... I wonder if the prefix should be "di" instead of "dip", we've never really used "dip" before, we tend to use "di".
/cc @dlongley @davidlehn
|
+1 and I agree that |
davidlehn
reviewed
Oct 25, 2024
Co-authored-by: David I. Lehn <[email protected]>
David-Chadwick
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5
Spec references:
There may be some small errors in the examples but I hope this enough to get started.