Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style regressions from #2801 #2803

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Oct 6, 2024

Regression from #2801.

During testing, it looked good, but in production it introduced some styling issues.

@florian-h05 florian-h05 requested a review from ghys as a code owner October 6, 2024 23:03
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI regression labels Oct 6, 2024
@florian-h05 florian-h05 added this to the 4.3 milestone Oct 6, 2024
Copy link

relativeci bot commented Oct 6, 2024

#2365 Bundle Size — 10.84MiB (~+0.01%).

f229375(current) vs 3efc1a8 main#2363(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2365
     Baseline
#2363
No change  Initial JS 1.89MiB 1.89MiB
Regression  Initial CSS 577.23KiB(+0.04%) 577.02KiB
Change  Cache Invalidation 24.09% 22.68%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2919 2919
No change  Duplicate Modules 149 149
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2365
     Baseline
#2363
No change  JS 9.05MiB 9.05MiB
Regression  CSS 864KiB (+0.02%) 863.79KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch florian-h05:2801-regressionProject dashboard


Generated by RelativeCIDocumentationReport issue

@florian-h05 florian-h05 changed the title Fix style regressions with oh-card margin Fix style regressions from #2801 Oct 6, 2024
@florian-h05 florian-h05 merged commit 2dc7d72 into openhab:main Oct 6, 2024
8 checks passed
@florian-h05 florian-h05 deleted the 2801-regression branch October 6, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant