Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom page icon size for openHAB icons #2445

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix custom page icon size for openHAB icons #2445

merged 1 commit into from
Mar 4, 2024

Conversation

florian-h05
Copy link
Contributor

@florian-h05
Fix custom page icon size for openHAB icons
0873550 
Regression from openhab#2340.

Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 requested a review from a team as a code owner March 4, 2024 10:33
@relativeci RelativeCI
Copy link

relativeci bot commented Mar 4, 2024

Job #1764: Bundle Size — 11.13MiB (~+0.01%).

0873550(current) vs 0f343f3 main#1763(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #1764		      Baseline
Job #1763
Regression  Initial JS 1.84MiB(~+0.01%) 1.84MiB
No change  Initial CSS 607.88KiB 607.88KiB
Change  Cache Invalidation 21.86% 16.75%
No change  Chunks 220 220
No change  Assets 243 243
No change  Modules 3091 3091
No change  Duplicate Modules 164 164
No change  Duplicate Code 1.75% 1.75%
No change  Packages 151 151
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1764		      Baseline
Job #1763
Regression  JS 9.31MiB (~+0.01%) 9.31MiB
Not changed  CSS 889.35KiB 889.35KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1764 report View florian-h05:page-icon-fix-size branch activity View project dashboard

@florian-h05 florian-h05 added this to the 4.2 milestone Mar 4, 2024
@florian-h05 florian-h05 merged commit da80fbd into openhab:main Mar 4, 2024
6 checks passed
@florian-h05 florian-h05 deleted the page-icon-fix-size branch March 4, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
main ui Main UI regression
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
1 participant
@florian-h05