-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widget expressions: Add #
as a shorthand for item.numericState
#2441
Conversation
Signed-off-by: Jimmy Tanagra <[email protected]>
Job #1759: Bundle Size — 11.13MiB (~+0.01%).Warning Bundle contains 19 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
View job #1759 report View jimtng:numericstate-shortcut branch activity View project dashboard |
Would |
It's a matter of opinion, I guess. I'd rather it be a single I picked # because it's often used as "number" e.g. "My #1 OS is Linux" whereas |
bundles/org.openhab.ui/web/src/components/widgets/widget-mixin.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Jimmy Tanagra <[email protected]>
Signed-off-by: Jimmy Tanagra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks 👍
Just in time for the first milestone of openHAB 4.2.0 🙌
#
as a shorthand for item.numericState#
as a shorthand for item.numericState
Refs openhab/openhab-webui#2441. Signed-off-by: Florian Hotze <[email protected]>
* Widget expressions Add docs for `#` shortcut Refs openhab/openhab-webui#2441. Signed-off-by: Florian Hotze <[email protected]> * Address review Signed-off-by: Florian Hotze <[email protected]> * Fix markdownlint Signed-off-by: Florian Hotze <[email protected]> --------- Signed-off-by: Florian Hotze <[email protected]>
See: openhab/openhab-core#4123
Add
#
alongside the existing shorthands:Yes, the docs will be updated if/after this is merged.