Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oh-repeater: Make caching configurable #1963

Merged
merged 4 commits into from
Jul 15, 2023
Merged

oh-repeater: Make caching configurable #1963

merged 4 commits into from
Jul 15, 2023

Conversation

florian-h05
Copy link
Contributor

Fixes #1956.

Adds a boolean property to the repeater (and relevant docs), cacheSource which allows the user to determine whether the repeater should refresh the source array with css and object changes or cache the source array for performance improvements.

Signed-off-by : Justin Georgi [email protected]

JustinGeorgi and others added 4 commits July 11, 2023 22:01
@florian-h05 florian-h05 requested a review from a team as a code owner July 15, 2023 21:48
@florian-h05
Copy link
Contributor Author

Supersedes #1961, where lint was failing and the contributor was not available to fix it and I was not able to push to his branch.
As I just opened this PR and did not author it, I’ll self-merge.

@relativeci
Copy link

relativeci bot commented Jul 15, 2023

Job #1060: Bundle Size — 15.74MiB (~-0.01%).

2856af1(current) vs e232f69 main#1059(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (1 change)
                 Current
Job #1060
     Baseline
Job #1059
Initial JS 1.67MiB(~+0.01%) 1.67MiB
Initial CSS 608.89KiB 608.89KiB
Cache Invalidation 93.94% 93.94%
Chunks 219 219
Assets 689 689
Modules 1700 1700
Duplicate Modules 90 90
Duplicate Code 1.95% 1.95%
Packages 138 138
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #1060
     Baseline
Job #1059
CSS 859.34KiB 859.34KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.24MiB (~-0.01%) 9.24MiB
Media 295.6KiB 295.6KiB
Other 4.72MiB (~-0.01%) 4.72MiB

View job #1060 reportView main branch activity

@florian-h05 florian-h05 merged commit f51c238 into openhab:main Jul 15, 2023
4 checks passed
@florian-h05 florian-h05 added this to the 4.0 milestone Jul 15, 2023
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jul 15, 2023
@florian-h05 florian-h05 deleted the florian-h05-patch-1 branch July 15, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeater static values vs dynamic refresh
2 participants