Skip to content

Commit

Permalink
Thing details: Fix config action Thing config modification (#2786)
Browse files Browse the repository at this point in the history 
Follow-up for #2775.
Fixes #2782.

Signed-off-by: Florian Hotze <[email protected]>
  • Loading branch information
@florian-h05
florian-h05 authored Oct 1, 2024
1 parent e272807 commit e2c3c53
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions bundles/org.openhab.ui/web/src/pages/settings/things/thing-details.vue
View file
Original file line number Diff line number Diff line change
Expand Up @@ -562,11 +562,10 @@ export default {
prompt,
this.thing.label,
() => {
const name = action.name
// Make sure Vue reactivity notices the change
this.$set(this.thing, 'configuration', ({
name: true,
...this.thing.configuration
...this.thing.configuration,
[action.name]: true
}))
// Vue reactivity is too slow to recognize config change before the API call, manually mark the config dirty
this.configDirty = true
Expand Down

1 comment on commit e2c3c53

@apella12
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested today with OH4.3 snapshot 4301 all is fine from the UI Controller Thing tab. Thanks!

2024-10-02 09:28:11.140 [DEBUG] [zwave.handler.ZWaveControllerHandler] - Controller Configuration update controller_exclude to true
2024-10-02 09:28:11.144 [DEBUG] [ve.internal.protocol.ZWaveController] - Event listener added.
2024-10-02 09:28:11.147 [DEBUG] [al.protocol.ZWaveInclusionController] - ZWave controller start exclusion
2024-10-02 09:28:11.151 [DEBUG] [serialmessage.RemoveNodeMessageClass] - Setting controller into EXCLUSION mode.

Separately ANY change on the UI Controller Code tab causes the controller to reinitialize. It has been this way for some time (well over a year). I haven't mentioned before because I was using (as feature, not a bug) in giving forum advice as a quick way to reinitialize the controller. Just thought I would let you know in case that is a concern. Again, easy to avoid by using the UI controller thing tab now. No real reason under normal circumstances for user to edit the code tab.

Please sign in to comment.