[thing] Add toString overrides to ThingImpl & BridgeImpl #4382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is nice to have when working with Things in scripts. Signed-off-by: Florian Hotze <[email protected]>
florian-h05
changed the title
There was a problem hiding this comment.
Thanks, this seems useful.
I'd like to see the comment "Configuration is deliberately excluded because it might include sensitive data like passwords." in Javadoc - unfortunately, it will not be visible, as the Impl classes are not shown. Adding toString() to the interface Thing would probably clutter the interface too much.... So maybe just as a code comment in ThingImpl.java?
Signed-off-by: Florian Hotze <[email protected]>
Done 👍 |
holgerfriedrich
approved these changes
Sep 19, 2024
|
LGTM, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is nice to have when working with Things in scripts.
I have chosen to not include the config because the config might include sensitive data like passwords.